Change in vdsm[master]: VolumeMetadata: Metadata read utils

alitke at redhat.com alitke at redhat.com
Wed Nov 25 16:43:13 UTC 2015


Adam Litke has posted comments on this change.

Change subject: VolumeMetadata: Metadata read utils
......................................................................


Patch Set 18:

(1 comment)

https://gerrit.ovirt.org/#/c/41846/18/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:

Line 108:             meta = misc.readblock(lvm.lvPath(vgname, sd.METADATA),
Line 109:                                   offs * volume.METADATA_SIZE,
Line 110:                                   volume.METADATA_SIZE)
Line 111:             out = {}
Line 112:             for l in meta:
> We should but not now.
Done
Line 113:                 if l.startswith("EOF"):
Line 114:                     return out
Line 115:                 if l.find("=") < 0:
Line 116:                     continue


-- 
To view, visit https://gerrit.ovirt.org/41846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e02ad8138bae0b1d60b032662afbad15dd4feba
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list