Change in vdsm[master]: vm: move device attached check to device itself

mmirecki at redhat.com mmirecki at redhat.com
Wed Nov 25 14:13:13 UTC 2015


Marcin Mirecki has posted comments on this change.

Change subject: vm: move device attached check to device itself
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/48881/4/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

Line 56:                  if not a.startswith('__')]
Line 57:         return ' '.join(attrs)
Line 58: 
Line 59:     def is_attached_to(self, xml_string):
Line 60:         raise NotImplementedError("is_attached_to not imlemented for this" +
> Use this style for long lines:
Done
Line 61:                                   " device")
Line 62: 
Line 63: 
Line 64: class Generic(Base):


https://gerrit.ovirt.org/#/c/48881/4/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 423
Line 424
Line 425
Line 426
Line 427
> xpath is not used by any code now, so better make it private (_xpath).
Done


-- 
To view, visit https://gerrit.ovirt.org/48881
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4df478798bc774c1134ca36879abd809ea2b6380
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list