Change in vdsm[ovirt-3.6]: tests: Disable flaky test

fromani at redhat.com fromani at redhat.com
Wed Nov 25 12:44:00 UTC 2015


Hello Ido Barkan, Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/49166

to review the following change.

Change subject: tests: Disable flaky test
......................................................................

tests: Disable flaky test

testGetBondingOptions fails randomly in the CI for more than a week.
Mark it as broken tests until the test owner find time to fix it.

Change-Id: Ia67731147635edb2c83c8d38ae189821103b5500
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48870
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M tests/netinfoTests.py
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/49166/1

diff --git a/tests/netinfoTests.py b/tests/netinfoTests.py
index 94bf924..59335df 100644
--- a/tests/netinfoTests.py
+++ b/tests/netinfoTests.py
@@ -36,6 +36,7 @@
 from monkeypatch import MonkeyPatch, MonkeyPatchScope
 from testlib import VdsmTestCase as TestCaseBase, namedTemporaryDir
 from testValidation import ValidateRunningAsRoot, RequireBondingMod
+from testValidation import brokentest
 
 # speeds defined in ethtool
 ETHTOOL_SPEEDS = set([10, 100, 1000, 2500, 10000])
@@ -278,6 +279,7 @@
         self.assertIn('valid4', dhcpv6_ifaces)
         self.assertNotIn('expired3', dhcpv6_ifaces)
 
+    @brokentest("Skipped becasue it breaks randomly on the CI")
     @MonkeyPatch(netinfo, 'BONDING_DEFAULTS', netinfo.BONDING_DEFAULTS
                  if os.path.exists(netinfo.BONDING_DEFAULTS)
                  else '../vdsm/bonding-defaults.json')


-- 
To view, visit https://gerrit.ovirt.org/49166
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia67731147635edb2c83c8d38ae189821103b5500
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>


More information about the vdsm-patches mailing list