Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

nsoffer at redhat.com nsoffer at redhat.com
Tue Nov 24 23:51:32 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vm: unit test for vm._waitForDriveRemoval
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/48880/3/tests/vmTests.py
File tests/vmTests.py:

Line 1271:         drive = Drive({}, log=self.log, index=0, path='test_path', iface="")
Line 1272:         testvm = TestingVm(fake.Domain())
Line 1273: 
Line 1274:         testvm._dom = FakeVmDom(self.DRIVE_XML)
Line 1275:         testvm._waitForDriveRemoval(drive)
> We can count the sleeps in FakeVmDom
Much much better!
Line 1276: 
Line 1277:     @MonkeyPatch(config, 'getint', lambda x, y: 0)
Line 1278:     def test_wait_for_drive_removal_removed_on_x_check(self):
Line 1279:         drive = Drive({}, log=self.log, index=0, path='test_path', iface="")


-- 
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1f86e17132a7099f109a5e33407c56dde40df2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list