Change in vdsm[master]: Live Merge: Notice imageSyncVolumeChain errors

nsoffer at redhat.com nsoffer at redhat.com
Tue Nov 24 21:57:08 UTC 2015


Nir Soffer has submitted this change and it was merged.

Change subject: Live Merge: Notice imageSyncVolumeChain errors
......................................................................


Live Merge: Notice imageSyncVolumeChain errors

Currently we ignore errors from imageSyncVolumeChain when resolving a
completed live merge operation.  This could cause us to signal the
completion of a live merge operation to ovirt-engine without first
updating the storage metadata.  Instead, we should detect the error and
raise an exception so that the LiveMergeCleanupThread working on this
job will retry the operation later.

Change-Id: I5447d06b6aade97f71a3b7d6d7c73f9699c307d0
Bug-Url: https://bugzilla.redhat.com/1214342
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/45387
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Ala Hino <ahino at redhat.com>
Reviewed-by: Greg Padgett <gpadgett at redhat.com>
Tested-by: Greg Padgett <gpadgett at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Adam Litke: Verified
  Greg Padgett: Verified; Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Ala Hino: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/45387
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5447d06b6aade97f71a3b7d6d7c73f9699c307d0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list