Change in vdsm[master]: image: copy - set VM metadata images format to RAW

derez at redhat.com derez at redhat.com
Tue Nov 24 16:36:50 UTC 2015


Daniel Erez has posted comments on this change.

Change subject: image: copy - set VM metadata images format to RAW
......................................................................


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/49002/6/vdsm/storage/image.py
File vdsm/storage/image.py:

Line 67: 
Line 68: RENAME_RANDOM_STRING_LEN = 8
Line 69: 
Line 70: # Size in blocks of the conf file generated during RAM snapshot operation
Line 71: VM_CONF_SIZE_BLK = 20
> This size isn't referenced by the code which creates the VM conf volume.  H
The size is determined by the engine. I.e. the engine creates an image in size of 10K. So I don't think we could actually ensure that. However, since the issue is only with old/existing images, it shouldn't be a problem. New images are should already be created by engine as raw. See - https://gerrit.ovirt.org/#/c/48768/
Line 72: 
Line 73: # Temporary size of a volume when we optimize out the prezeroing
Line 74: TEMPORARY_VOLUME_SIZE = 20480  # in sectors (10M)
Line 75: 


Line 503:         mis-correlation.
Line 504:         """
Line 505:         format = srcVol.getFormat()
Line 506:         size_in_blk = srcVol.getSize()
Line 507:         if format == volume.COW_FORMAT and size_in_blk == VM_CONF_SIZE_BLK:
> Is there a better way to detect these volumes other than using the size?
Yeah, you're right, the thing is that we don't have a better way to identify these files... Any way, it affects only old files, new one should be created correctly by the engine - see - https://gerrit.ovirt.org/#/c/48768/
Line 508:             info = qemuimg.info(srcVol.getVolumePath())
Line 509:             actual_format = info['format']
Line 510: 
Line 511:             if actual_format == qemuimg.FORMAT.RAW:


-- 
To view, visit https://gerrit.ovirt.org/49002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icaad6599260a2631f580e17404d25554a19ec670
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list