Change in vdsm[ovirt-3.6]: vmstats: network: avoid ZeroDivisionError

mzamazal at redhat.com mzamazal at redhat.com
Tue Nov 24 14:22:46 UTC 2015


Milan Zamazal has posted comments on this change.

Change subject: vmstats: network: avoid ZeroDivisionError
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/48478/1/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:

Line 213:         return None
Line 214:     if interval <= 0:
Line 215:         logging.warning(
Line 216:             'invalid interval %i when computing network stats for vm %s',
Line 217:             interval, vm.id)
Is interval really integer?
Line 218:         return None
Line 219: 
Line 220:     first_indexes = _find_bulk_stats_reverse_map(first_sample, 'net')
Line 221:     last_indexes = _find_bulk_stats_reverse_map(last_sample, 'net')


-- 
To view, visit https://gerrit.ovirt.org/48478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ff99e3706212179ef9dc56e92e7d5decdd6bd7a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list