Change in vdsm[master]: image: copy - set VM metadata images format to RAW

derez at redhat.com derez at redhat.com
Tue Nov 24 12:31:13 UTC 2015


Daniel Erez has posted comments on this change.

Change subject: image: copy - set VM metadata images format to RAW
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/49002/3/vdsm/storage/image.py
File vdsm/storage/image.py:

Line 67: 
Line 68: RENAME_RANDOM_STRING_LEN = 8
Line 69: 
Line 70: # Size in blocks of the conf file generated during RAM snapshot operation
Line 71: VM_CONF_SIZE = 20
> why is it 20? is this the minimum we allocate everytime?
yeah, we create the disk with virtual size of 10K - i.e. 20 blocks.
Line 72: 
Line 73: # Temporary size of a volume when we optimize out the prezeroing
Line 74: TEMPORARY_VOLUME_SIZE = 20480  # in sectors (10M)
Line 75: 


-- 
To view, visit https://gerrit.ovirt.org/49002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icaad6599260a2631f580e17404d25554a19ec670
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list