Change in vdsm[master]: build: Cleanup conditionals in the build system

ybronhei at redhat.com ybronhei at redhat.com
Tue Nov 24 11:35:22 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: build: Cleanup conditionals in the build system
......................................................................


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/48446/14/vdsm.spec.in
File vdsm.spec.in:

Line 628: %endif
Line 629: %if ! 0%{with_gluster_mgmt}
Line 630:         --disable-gluster-mgmt \
Line 631: %endif
Line 632: if 0%{rhev_build}
> %if ...
OMG
but I ran it :/
Line 633:         --enable-rhev \
Line 634:         --enable-hooks \
Line 635:         --disable-gluster-mgmt \
Line 636:         --with-smbios-manufacturer='Red Hat' \


-- 
To view, visit https://gerrit.ovirt.org/48446
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c94d206eb94ba51752423831ce4e01214a6a6d3
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list