Change in vdsm[ovirt-3.6]: vm: periodic: NumaInfoMonitor doesn't need jobs

fromani at redhat.com fromani at redhat.com
Tue Nov 24 08:03:09 UTC 2015


Francesco Romani has submitted this change and it was merged.

Change subject: vm: periodic: NumaInfoMonitor doesn't need jobs
......................................................................


vm: periodic: NumaInfoMonitor doesn't need jobs

The Vm.isDomainReadyForCommands() is a borderline hack
that relies on virDomainGetControlInfo, which, in turn,
tells the caller about the hypervisor monitor traffic.

In the case of NumaInfoMonitor, this protection has zero
positive value (only adds libvirt traffic) because
the libvirt API used internally by NumaInfoMonitor do not
need to access the QEMU monitor, but only data from /proc.

Hence, remove the call to reduce libvirt traffic and
to reduce false negative reported:

periodic/3::WARNING::2015-08-12
15:02:57,855::periodic::253::virt.periodic.VmDispatcher::(__call__)
could not run <class 'virt.periodic.NumaInfoMonitor'> on
[u'5b44bc17-99ba-4c9d-a3c5-fcd913c87361']

X-Backport-To: 3.6
Change-Id: I50c68b8b00ea0f9c137ce8149f3a806c62be7f6d
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/44763
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Continuous-Integration: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48411
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal <mzamazal at redhat.com>
---
M vdsm/virt/periodic.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Francesco Romani: Verified; Looks good to me, approved
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/48411
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I50c68b8b00ea0f9c137ce8149f3a806c62be7f6d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list