Change in vdsm[ovirt-3.5]: netinfo: report DHCP from configuration to avoid confusion a...

osvoboda at redhat.com osvoboda at redhat.com
Tue Nov 24 00:28:26 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: netinfo: report DHCP from configuration to avoid confusion after stopping DHCP
......................................................................


Patch Set 2:

What sort of dependence don't you like? Just the fact that we import netconfpersistence (and that something could be done to break the circular dependency that currently exists) or the whole concept of using network configuration for reporting?

While I find https://gerrit.ovirt.org/#/c/48913/ very confusing and hacky (one module alters another's data), I am and have been fully in support of https://gerrit.ovirt.org/#/c/48824.

Just for the sake of reporting correct values I don't want to put my hands on another program's stuff.

dhclient leases have their application. When a network is configured back to DHCP while a previous lease has not expired yet, the system is then likely to be granted the same configuration it had before thanks to just renewing the lease.

Once you manage to remove KernelConfig from netconfpersistence there won't be a cycle anymore and there shouldn't be a problem either. We are still not decided whether to try other ways of assessing DHCP is used, and the one is looking at dhclient processes again.

-- 
To view, visit https://gerrit.ovirt.org/48846
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I11848101731c1d787e5b5b9c1f8fdb8a4eed6599
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list