Change in vdsm[master]: vm: unit test for vm._waitForDriveRemoval

nsoffer at redhat.com nsoffer at redhat.com
Mon Nov 23 23:15:27 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vm: unit test for vm._waitForDriveRemoval
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/48880/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 145: 
Line 146:         ('hotunplug_timeout', '30',
Line 147:             'Time to wait (in seconds) for a VM to detach its disk'),
Line 148: 
Line 149:         ('hotunplug_sleep_time', '1',
Maybe hotunplug_check_interval?

Sleep is the current way we implement the check. Tomorrow we can use timer instead. The name should describe what we do, not how we do it.
Line 150:             'Sleep time between consecutive checks for VM device detach'),
Line 151: 
Line 152:         ('vm_watermark_interval', '2',
Line 153:             'How often should we check drive watermark on block storage for '


Line 146:         ('hotunplug_timeout', '30',
Line 147:             'Time to wait (in seconds) for a VM to detach its disk'),
Line 148: 
Line 149:         ('hotunplug_sleep_time', '1',
Line 150:             'Sleep time between consecutive checks for VM device detach'),
Maybe "Time to wait (in seconds) between consecutive checks for device removal"
Line 151: 
Line 152:         ('vm_watermark_interval', '2',
Line 153:             'How often should we check drive watermark on block storage for '
Line 154:             'automatic extension of thin provisioned volumes (seconds).'),


-- 
To view, visit https://gerrit.ovirt.org/48880
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d1f86e17132a7099f109a5e33407c56dde40df2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list