Change in vdsm[master]: vm: move device attached check to device itself

mmirecki at redhat.com mmirecki at redhat.com
Mon Nov 23 21:27:45 UTC 2015


Marcin Mirecki has posted comments on this change.

Change subject: vm: move device attached check to device itself
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/48881/1/tests/vmTests.py
File tests/vmTests.py:

Line 1253
Line 1254
Line 1255
Line 1256
Line 1257
> Name should also work as parameter.
We don't need the name. Only required for logging.
Removing it.


Line 1252:             testvm._dom = fake.Domain(vmId='testvm')
Line 1253:             self.assertFalse(response.is_error(testvm.acpiShutdown()))
Line 1254: 
Line 1255:     def test_wait_for_device_removal(self):
Line 1256:         drive = Drive({}, log=self.log, index=0, path='test_path', iface="")
> diskType can be given as parameter - we use it only for "network" type but 
The default diskType is FILE, we don't need it at all.
Line 1257:         drive.name = ''
Line 1258:         drive.diskType = DISK_TYPE.FILE
Line 1259:         with fake.VM() as testvm:
Line 1260:             testvm._dom = FakeVmDom(999)


Line 1254: 
Line 1255:     def test_wait_for_device_removal(self):
Line 1256:         drive = Drive({}, log=self.log, index=0, path='test_path', iface="")
Line 1257:         drive.name = ''
Line 1258:         drive.diskType = DISK_TYPE.FILE
> You should use this code in the patch adding this test.
Removed
Line 1259:         with fake.VM() as testvm:
Line 1260:             testvm._dom = FakeVmDom(999)
Line 1261:             testvm._hotunplug_timeout = 1
Line 1262:             try:


-- 
To view, visit https://gerrit.ovirt.org/48881
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4df478798bc774c1134ca36879abd809ea2b6380
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list