Change in vdsm[master]: gluster: Remove duplicate servers

ahino at redhat.com ahino at redhat.com
Mon Nov 23 20:06:22 UTC 2015


Ala Hino has posted comments on this change.

Change subject: gluster: Remove duplicate servers
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/49023/1/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:

Line 338:             raise se.UnsupportedGlusterVolumeReplicaCountError(replicaCount)
Line 339: 
Line 340:     def _get_backup_servers_option(self):
Line 341:         servers = OrderedDict.fromkeys([brick.split(":")[0] for brick
Line 342:                                        in self.volinfo['bricks']]).keys()
> How about adding a utility function in utils?
Yup - having a unique util making the code more readable
Line 343:         self.log.debug("Using bricks: %s", servers)
Line 344:         if self._volfileserver in servers:
Line 345:             servers.remove(self._volfileserver)
Line 346:         else:


-- 
To view, visit https://gerrit.ovirt.org/49023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I10fd0c985e7fe024460faa288fc790e761da4811
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list