Change in vdsm[master]: net: remove mac address from ifcfg

danken at redhat.com danken at redhat.com
Mon Nov 23 15:32:11 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: remove mac address from ifcfg
......................................................................


net: remove mac address from ifcfg

In el7, the HWADDR field in ifcfg files is no longer needed by udev
and is considered a bad practice. Hence, VDSM shouldn't handle it
anymore.

Change-Id: I4fa6f01f3232ed6bf0fca1d68061b2e90a54209a
Signed-off-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48579
Continuous-Integration: Jenkins CI
Reviewed-by: Ondřej Svoboda <osvoboda at redhat.com>
Reviewed-by: Edward Haas <edwardh at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/config.py.in
M vdsm/network/configurators/ifcfg.py
2 files changed, 1 insertion(+), 38 deletions(-)

Approvals:
  Ido Barkan: Verified
  Ondřej Svoboda: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/48579
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4fa6f01f3232ed6bf0fca1d68061b2e90a54209a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list