Change in vdsm[ovirt-3.5.6]: hotunplug: support python 2.6

fromani at redhat.com fromani at redhat.com
Mon Nov 23 14:53:58 UTC 2015


Francesco Romani has submitted this change and it was merged.

Change subject: hotunplug: support python 2.6
......................................................................


hotunplug: support python 2.6

In commit d0d05b02ee, we introduced a libvirt quering method to find
out if a drive was attached to a VM.

However- The XPath expression used in this method is supported only in
ElementTree1.3: http://effbot.org/zone/element-xpath.htm, which was only
introduced in Python 2.7:
https://docs.python.org/2/library/xml.etree.elementtree.html

As VDSM needs to support Python2.6 on RHEL6, this patch changes the
method to work with ElementTreee x.y available in Python 2.6.

Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Bug-Url: https://bugzilla.redhat.com/1283287
Label: ovirt-3.5-only
Signed-off-by: Amit Aviram <aaviram at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48916
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
Continuous-Integration: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/49007
Tested-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Francesco Romani: Verified; Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/49007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia89620ff3aab14dc09373c44c8567b74e2103a60
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5.6
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list