Change in vdsm[master]: virt: vm: Update time on VM after resume

fromani at redhat.com fromani at redhat.com
Mon Nov 23 13:40:14 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/48860/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2808: 
Line 2809:             for dev in self._customDevices():
Line 2810:                 hooks.after_device_migrate_destination(
Line 2811:                     dev._deviceXML, self.conf, dev.custom)
Line 2812:         self._setTime()
> > do we want to do this also in the migration destination path? 
ok, let's save this for another (trivial) patch. For this patch, please call setTime() only in the dehibernation path. Feel free to add a TODO in the other path if you want, to act as reminder.
Line 2813: 
Line 2814:         if 'guestIPs' in self.conf:
Line 2815:             del self.conf['guestIPs']
Line 2816:         if 'guestFQDN' in self.conf:


-- 
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list