Change in vdsm[master]: exception: Gather exceptions in vdsm.exception

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Nov 23 09:31:07 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: exception: Gather exceptions in vdsm.exception
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/48868/3//COMMIT_MSG
Commit Message:

Line 12: have one exception module
I am not sure whether this is good approach for errors like JsonRpcError and all that inherit from it.

When we start to using external to vdsm clients we do not want to have too many dependencies on vdsm.


-- 
To view, visit https://gerrit.ovirt.org/48868
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I076a7a381003053e7655ef5bece17c00ce9a92ca
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list