Change in vdsm[master]: betterAsyncore: Send pending data without polling

nsoffer at redhat.com nsoffer at redhat.com
Mon Nov 23 09:07:15 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: betterAsyncore: Send pending data without polling
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/48887/2/lib/yajsonrpc/betterAsyncore.py
File lib/yajsonrpc/betterAsyncore.py:

Line 164:     def set(self):
Line 165:         self._eventfd.write(1)
Line 166: 
Line 167:     def handle_read(self):
Line 168:         self.wokeup = True
> It would set it after reading not before due errors like EAGAIN.
My assumption is that the signalfd becomes readable only when you write to it. So calling handle_write means the event was signaled and the reactor was woken up.

I don't care if the read succeed or not, unless it is this api is known to have spurious wakeups, and we can detect them by reading.
Line 169:         self._eventfd.read()
Line 170: 
Line 171:     def close(self):
Line 172:         try:


-- 
To view, visit https://gerrit.ovirt.org/48887
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c0f76660e7b4c31f87af342428a533a6045ddad
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list