Change in vdsm[master]: lib: executor: log pool status on discard
nsoffer at redhat.com
nsoffer at redhat.com
Mon Nov 23 09:02:32 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: lib: executor: log pool status on discard
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/48333/5/lib/vdsm/executor.py
File lib/vdsm/executor.py:
Line 113: # this is a debug aid, it is not that important to be precise;
Line 114: # intentionally done outside the lock
Line 115: self._log.info('pool[%i]: (%s)',
Line 116: len(self._workers),
Line 117: ' '.join(str(w) for w in self._workers))
This is not informational message, its a debugging message.
If this was unexpected situation it could be a warning, but expect this to happen from time to time, so lets have a debug message.
This notation is not very clear pool[12]: (<Worker ...> <Worker ...>).
How about:
"count=%d workers=%s", len(self._workers), self._workers
Formatting a list of object with __repr__ should work without additional code.
See https://gerrit.ovirt.org/48865
Line 118:
Line 119: def _worker_stopped(self, worker):
Line 120: """
Line 121: Called from worker thread before it exit.
--
To view, visit https://gerrit.ovirt.org/48333
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I949181968a97a7bcec703bc36ef9e1a0f30c6858
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list