Change in vdsm[master]: hooks: ovs: pass ip configuration as a namedtuple
ibarkan at redhat.com
ibarkan at redhat.com
Mon Nov 23 05:23:11 UTC 2015
Ido Barkan has posted comments on this change.
Change subject: hooks: ovs: pass ip configuration as a namedtuple
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/48830/1/vdsm_hooks/ovs/ovs_before_network_setup_ip.py
File vdsm_hooks/ovs/ovs_before_network_setup_ip.py:
Line 35:
Line 36:
Line 37: iproute2 = Iproute2()
Line 38:
Line 39: IPConfig = namedtuple('IPConfig', ['top_dev', 'ipv4', 'ipv6', 'port',
namedTuples are cool but evil. Ondrej has tried very hard to get rid of them in VDSM. If you need a class, write it. It will serve later readers. is reusing models.IPv4 possible here?
Line 40: 'blocking_dhcp'])
Line 41:
Line 42:
Line 43: def _get_ipv4_model(attrs):
--
To view, visit https://gerrit.ovirt.org/48830
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I59aa8f72272486a9bfa978407590c347acfc0664
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list