Change in vdsm[master]: build: Cleanup conditionals in the build system

ybronhei at redhat.com ybronhei at redhat.com
Sun Nov 22 13:49:52 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: build: Cleanup conditionals in the build system
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/48446/11/configure.ac
File configure.ac:

Line 52:     ,
Line 53:     [enable_hooks="no"]
Line 54: )
Line 55: AM_CONDITIONAL([HOOKS], [test "${enable_hooks}" = "yes"])
Line 56: AC_SUBST([HOOKS], ["${enable_hooks}"])
> Will this work for getting 0 or 1?
no :\

changing all yes\no to 1 0 works for defaults , but AM_CONFITIONAL changes it to yes\no. searching for magic to avoid that..
Line 57: 
Line 58: AC_ARG_ENABLE(
Line 59:     [gluster-mgmt],
Line 60:     [AS_HELP_STRING(


-- 
To view, visit https://gerrit.ovirt.org/48446
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c94d206eb94ba51752423831ce4e01214a6a6d3
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list