Change in vdsm[master]: vm: snapshot - use r+ to open vm conf file

nsoffer at redhat.com nsoffer at redhat.com
Sun Nov 22 09:58:01 UTC 2015


Nir Soffer has submitted this change and it was merged.

Change subject: vm: snapshot - use r+ to open vm conf file
......................................................................


vm: snapshot - use r+ to open vm conf file

Since commit 0b61c4851a528fd6354d9ab77a68085c41f35dc9
copy of internal raw volumes is done using 'qemu-img convert'
instead of invoking 'dd'. Hence, we should avoid changing
the file size by opening it in a non-truncate mode to avoid
qemu-img from hanging during the convert operation.

The issue reproduces for files size of multiplicity of 512.
E.g.
Doesn't work:
$ dd if=/dev/zero of=/tmp/test.raw bs=5474 count=1
$ ./qemu-img convert -p -t none -T none -O raw /tmp/test.raw
/tmp/dest.raw

Works:
$ dd if=/dev/zero of=/tmp/test.raw bs=5120 count=1
$ ./qemu-img convert -p -t none -T none -O raw /tmp/test.raw
/tmp/dest.raw

Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49
Bug-Url: https://bugzilla.redhat.com/1282239
Relates-To: https://bugzilla.redhat.com/1229394
Signed-off-by: Daniel Erez <derez at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48776
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Continuous-Integration: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, approved; Passed CI tests
  Daniel Erez: Verified
  Francesco Romani: Looks good to me, approved

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/48776
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6799e07898155fd4a630bfaf4151ea9ccdcee49
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list