Change in vdsm[master]: mkimage: check image attributes after creation
fromani at redhat.com
fromani at redhat.com
Fri Nov 20 16:29:57 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: mkimage: check image attributes after creation
......................................................................
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/48540/2/vdsm/mkimage.py
File vdsm/mkimage.py:
Line 138: os.close(fd)
Line 139:
Line 140: uid = resolveUid(DISKIMAGE_USER)
Line 141: gid = resolveGid(DISKIMAGE_GROUP)
Line 142: os.chown(isopath, uid, gid)
> This is already done in _commonCleanFs, and is not needed. Until we finishe
inherited from parent patch, will go away in next upload
Line 143:
Line 144: rc, out, err = execCmd(command, raw=True)
Line 145: if rc:
Line 146: raise OSError(errno.EIO, "could not create iso file: "
Line 145: if rc:
Line 146: raise OSError(errno.EIO, "could not create iso file: "
Line 147: "code %s, out %s\nerr %s" % (rc, out, err))
Line 148:
Line 149: _check_attributes(isopath, uid, gid, mode):
> We need only the permission check, as _commonCleanFs already set the correc
Done
Line 150:
Line 151: finally:
Line 152: _commonCleanFs(dirname, isopath)
Line 153:
--
To view, visit https://gerrit.ovirt.org/48540
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3823dc604b2bafecc49154491d1815670a3600fa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list