Change in vdsm[master]: migration: added support for convergance schedule
fromani at redhat.com
fromani at redhat.com
Fri Nov 20 14:23:57 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: migration: added support for convergance schedule
......................................................................
Patch Set 8:
(2 comments)
initial comments, deeper review later
https://gerrit.ovirt.org/#/c/46940/8/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 121: self._use_convergence_schedule = False
Line 122: if 'convergenceSchedule' in kwargs:
Line 123: # example convergence schedule
Line 124: # [[], [1, ["setDowntime", [10]]], [4, ["abort", []]]]
Line 125: schedule = json.loads(kwargs.get('convergenceSchedule'))
this can raise. What can we do in this case? just explode or continue with the default schedule?
Line 126: self._use_convergence_schedule = True
Line 127:
Line 128: self._convergence_schedule = (
Line 129: [
Line 134: for lim, (act, params) in schedule[1]
Line 135: ]
Line 136: )
Line 137:
Line 138: self.log.debug('convergence schedule set to: '+str(self._convergence_schedule))
let's use
self.log.debug('convergence schedule set to: ', str(self._convergence_schedule))
Line 139:
Line 140:
Line 141: @property
Line 142: def hibernating(self):
--
To view, visit https://gerrit.ovirt.org/46940
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I989cff12d08ef1cab36bd10df7daaa999a8dac14
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list