Change in vdsm[master]: misc: remove rotateFiles

nsoffer at redhat.com nsoffer at redhat.com
Fri Nov 20 11:34:29 UTC 2015


Nir Soffer has submitted this change and it was merged.

Change subject: misc: remove rotateFiles
......................................................................


misc: remove rotateFiles

Since commit 8bc23a66b409 (Make misc.py conform pep8 and other minor
cleanup) in March 2012, rotateFiles does *nothing*. The tests
are also broken; they pass while the function does nothing.

Change-Id: I1abd244253ba9be64e8eee6daaeb785a18a150f0
Signed-off-by: Yeela Kaplan <ykaplan at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48577
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Tested-by: Nir Soffer <nsoffer at redhat.com>
Continuous-Integration: Jenkins CI
---
M tests/miscTests.py
M vdsm/storage/misc.py
M vdsm/storage/sd.py
3 files changed, 1 insertion(+), 104 deletions(-)

Approvals:
  Nir Soffer: Verified; Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/48577
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1abd244253ba9be64e8eee6daaeb785a18a150f0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list