Change in vdsm[master]: build: Introduce --enable-gluster-mgmt option

nsoffer at redhat.com nsoffer at redhat.com
Fri Nov 20 11:33:13 UTC 2015


Nir Soffer has submitted this change and it was merged.

Change subject: build: Introduce --enable-gluster-mgmt option
......................................................................


build: Introduce --enable-gluster-mgmt option

Previously building gluster package and building for RHEV were coupled
together in an ugly way. We disabled gluster package when building for
RHEV, and enabled some gluster apis only when building for RHEV.

We want to get rid of these downstream related options, but we also want
to allow downstream maintainers easy way to configure the package as
needed.

This patch decouples rhev_build and with_gluster options; To build the
vdsm-gluster package, use:

    ./configure --enable-gluster-mgmt

To build without vdsm-gluster package, use:

    ./configure --disable-gluster-mgmt

When gluster-mgmt is enabled, supervdsm exposes all gluster apis marked
with @gluster_mgmt_api decorator. Most of these apis are used when vdsm
is used to control gluster server.

When gluster-mgmt is disabled, supervdsm exposes only the gluster vdsm
apis marked as with @gluster_api. These apis are required for consuming
gluster storage.

Change-Id: I84608625e3b004c64b4928e5325d9375fb952878
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/46708
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
Tested-by: Yaniv Bronhaim <ybronhei at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M Makefile.am
M configure.ac
M lib/vdsm/constants.py.in
M vdsm.spec.in
M vdsm/gluster/Makefile.am
M vdsm/gluster/__init__.py
M vdsm/gluster/cli.py
M vdsm/supervdsmServer
8 files changed, 91 insertions(+), 74 deletions(-)

Approvals:
  Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/46708
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I84608625e3b004c64b4928e5325d9375fb952878
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list