Change in vdsm[master]: tests: Test both ssl and m2c

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Fri Nov 20 08:09:46 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: tests: Test both ssl and m2c
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.ovirt.org/#/c/48823/2/tests/integration/__init__.py
File tests/integration/__init__.py:

Line 16: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: from . import m2chelper, sslhelper
> Can you import m2chelper if M2Crypto is not installed (e.g. on debian)?
Good, point will fix it.
Line 21: from vdsm import m2cutils, sslutils
Line 22: 
Line 23: 
Line 24: def get_context(impl):


https://gerrit.ovirt.org/#/c/48823/2/tests/stompTests.py
File tests/stompTests.py:

Line 55: @expandPermutations
Line 56: class StompTests(TestCaseBase):
Line 57: 
Line 58:     @permutations([[size, impl]
Line 59:                    for impl in ['ssl', 'm2c']
> Use [None, 'ssl', 'm2c']
will add None as well.
Line 60:                    for size in [1, 1024, 4096, 16384]])
Line 61:     def test_echo(self, size, impl):
Line 62:         data = dummyTextGenerator(size)
Line 63:         sslctx = integration.get_context(impl)


Line 59:                    for impl in ['ssl', 'm2c']
Line 60:                    for size in [1, 1024, 4096, 16384]])
Line 61:     def test_echo(self, size, impl):
Line 62:         data = dummyTextGenerator(size)
Line 63:         sslctx = integration.get_context(impl)
> And:
Done
Line 64:         with MonkeyPatchScope([(protocoldetector, 'SSLHandshakeDispatcher',
Line 65:                                 integration.get_dispatcher(impl))]):
Line 66:             with constructAcceptor(self.log, sslctx,
Line 67:                                    _SampleBridge()) as acceptor:


-- 
To view, visit https://gerrit.ovirt.org/48823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa6415c68261f0458b2befa1139b3c8f155820ac
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list