Change in vdsm[master]: vdsm: introduce cpuinfo module

nsoffer at redhat.com nsoffer at redhat.com
Thu Nov 19 21:46:48 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vdsm: introduce cpuinfo module
......................................................................


Patch Set 13: Code-Review-1

(1 comment)

Partial review of cpuinfo module.

https://gerrit.ovirt.org/#/c/46912/13/lib/vdsm/cpuarch.py
File lib/vdsm/cpuarch.py:

Line 49:     def __init__(self, target_arch=None):
Line 50:         if not target_arch:
Line 51:             target_arch = current()
Line 52: 
Line 53:         super(UnsupportedArchitecture, self).__init__(target_arch)
- The caller should give the architecture, no defaults and no magic.
- No need to initialize the parent.
- Implement __str__ to return helpful message instead of meaningless tuple of args
Line 54: 
Line 55: 
Line 56: def arch_to_cpu_map(target_arch=None):
Line 57:     '''


-- 
To view, visit https://gerrit.ovirt.org/46912
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa702b05f3825ebdcfed16d86d39a8c38fcf224c
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list