Change in vdsm[master]: build: Cleanup conditionals in the build system

nsoffer at redhat.com nsoffer at redhat.com
Wed Nov 18 18:36:44 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: build: Cleanup conditionals in the build system
......................................................................


Patch Set 11: Code-Review-1

00:00:51.970 error: parse error in expression
00:00:51.970 error: /home/jenkins/workspace/vdsm_master_install-rpm-sanity-fc22_created/rpmbuild/SPECS/vdsm.spec:43: bad %if condition

This is not valid spec:

    if %{foo} == 'yes'

This is why I change all the conditional in version 4.

I'm not happy with adding unrelated stuff under
rehv-build - it means that both --disable-gluster-mgmt and 
--enable-hooks are ignored in this case.

This also means that we will have to change the spec if 
the requirement changes.

We should have orthogonal options.

-- 
To view, visit https://gerrit.ovirt.org/48446
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c94d206eb94ba51752423831ce4e01214a6a6d3
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Barak Korren <bkorren at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list