Change in vdsm[master]: misc: remove rotateFiles

ykaplan at redhat.com ykaplan at redhat.com
Wed Nov 18 09:48:32 UTC 2015


Yeela Kaplan has posted comments on this change.

Change subject: misc: remove rotateFiles
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/48577/3//COMMIT_MSG
Commit Message:

Line 10: many years now.
Line 11: Making it unnecessary.
Line 12: While removing the last usage of rotateFiles
Line 13: that is in sd setMetadata, we can
Line 14: now remove this unused method.
> Can you update the text to explain:
I'm not sure it was ever working.
Line 15: 
Line 16: Change-Id: I1abd244253ba9be64e8eee6daaeb785a18a150f0


https://gerrit.ovirt.org/#/c/48577/3/vdsm/storage/sd.py
File vdsm/storage/sd.py:

Line 874
Line 875
Line 876
Line 877
Line 878
> Can you remove only the call to rotate files? Lets do small and simple chan
Done


-- 
To view, visit https://gerrit.ovirt.org/48577
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1abd244253ba9be64e8eee6daaeb785a18a150f0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list