Change in vdsm[master]: v2v: _add_disk_info hides error when probbing for disk infor...

shavivi at redhat.com shavivi at redhat.com
Wed Nov 18 09:15:33 UTC 2015


Shahar Havivi has uploaded a new change for review.

Change subject: v2v: _add_disk_info hides error when probbing for disk information
......................................................................

v2v: _add_disk_info hides error when probbing for disk information

If storageVolLookupByPath fails we need to fail the action.

Change-Id: I7ac8f724952c475445e0d0481b44a679006f7fa4
Signed-off-by: Shahar Havivi <shaharh at redhat.com>
---
M vdsm/v2v.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/48707/1

diff --git a/vdsm/v2v.py b/vdsm/v2v.py
index f896d13..36c78df 100644
--- a/vdsm/v2v.py
+++ b/vdsm/v2v.py
@@ -690,9 +690,9 @@
         try:
             vol = conn.storageVolLookupByPath(disk['alias'])
             _, capacity, alloc = vol.info()
-        except libvirt.libvirtError:
-            logging.exception("Error getting disk size")
-
+        except libvirt.libvirtError as ex:
+            logging.exception("Error getting disk size: %s" % ex.message)
+            raise V2VError(ex.message)
         else:
             disk['capacity'] = str(capacity)
             disk['allocation'] = str(alloc)


-- 
To view, visit https://gerrit.ovirt.org/48707
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ac8f724952c475445e0d0481b44a679006f7fa4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>


More information about the vdsm-patches mailing list