Change in vdsm[master]: lib: sparsify: use common Error class

nsoffer at redhat.com nsoffer at redhat.com
Wed Nov 18 09:05:53 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: lib: sparsify: use common Error class
......................................................................


Patch Set 6:

I think the engine side does not exists, and you need complex setup. Don't waste time on this.

I would use manhole to run the function directly, possibly faking the actual command with /bin/false or /bin/true or some script returning output, and watch the new shiny exception raised.

-- 
To view, visit https://gerrit.ovirt.org/47965
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1cd56e513d99c82f237fb53876b6ced8fbebfde4
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list