Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

nsoffer at redhat.com nsoffer at redhat.com
Wed Nov 18 08:57:06 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: v2v: externalVMList Xen+Kvm support
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/48672/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 149:                            'message': e.message}}
Line 150: 
Line 151:     with closing(conn):
Line 152:         vms = []
Line 153:         for name in conn.listDefinedDomains():
> Not all new methods are supported in older version of libvirt.
This comment should be in the code: "We cannot use x because ... y is available on ...", and we should have a TODO - use x when we support Xen > z ...
Line 154:             params = {}
Line 155:             vm = conn.lookupByName(name)
Line 156:             _add_vm_info(vm, params)
Line 157:             try:


Line 651: 
Line 652: 
Line 653: def _add_vm_info(vm, params):
Line 654:     params['vmName'] = vm.name()
Line 655:     if vm.isActive():
> This is the way to know if the VM is up or down,
Same - need to explain this in the code, todo for using modern api.
Line 656:         params['status'] = "Up"
Line 657:     else:
Line 658:         params['status'] = "Down"
Line 659: 


-- 
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list