Change in vdsm[master]: hsm : Do not resize on disconnectStorageServer

nsoffer at redhat.com nsoffer at redhat.com
Tue Nov 17 21:50:53 UTC 2015


Nir Soffer has submitted this change and it was merged.

Change subject: hsm : Do not resize on disconnectStorageServer
......................................................................


hsm : Do not resize on disconnectStorageServer

When a host is moved to maintenance state, it will
disconnect from connected storage servers.

Then, sdCache.refreshStorage() is called. It will rescan
the devices, and attempt to resize devices if needed.

However, in this flow, resizing devices is not needed and may
cause exceptions when trying to access sysfs when the iscsi
connections are being removed, and needlessly delay the
maintenance operation.

Change-Id: I78e236a851b7a0e9ab8f3c86e180cc50fde4ad56
Bug-Url: https://bugzilla.redhat.com/1281909
Signed-off-by: Fred Rolland <frolland at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48578
Reviewed-by: Allon Mureinik <amureini at redhat.com>
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
Continuous-Integration: Jenkins CI
---
M vdsm/storage/hsm.py
M vdsm/storage/sdc.py
2 files changed, 4 insertions(+), 3 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Allon Mureinik: Looks good to me, but someone else must approve
  Freddy Rolland: Verified



-- 
To view, visit https://gerrit.ovirt.org/48578
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I78e236a851b7a0e9ab8f3c86e180cc50fde4ad56
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list