Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

nsoffer at redhat.com nsoffer at redhat.com
Tue Nov 17 20:45:56 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: v2v: externalVMList Xen+Kvm support
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/48672/1//COMMIT_MSG
Commit Message:

Line 14: 
Line 15: As well as for Xen (On Rhel 5.x)
Line 16: xen+ssh://user@host
Line 17: 
Line 18: Importing VMs from Xen and Kvm will be presented in the next patches
Can you explain what is the issues in adding this support, and how your patch is solving them?

Looking at the code, it looks like couple of random changes without a clear reason. This is probably because we don't see the whole picture.
Line 19: 
Line 20: Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4


-- 
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list