Change in vdsm[master]: storagetestlib: use a real metadata file for FileSD manifests

nsoffer at redhat.com nsoffer at redhat.com
Tue Nov 17 20:43:09 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: storagetestlib: use a real metadata file for FileSD manifests
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/48695/1//COMMIT_MSG
Commit Message:

Line 9: When building a fake FileStorageDomainManifest place the metadata in
Line 10: the right place within the domain's file hierarchy (as opposed to
Line 11: keeping it in memory).  This is needed since code in VolumeMetadata
Line 12: sometimes instantiates its controlling manifest and the metadata must be
Line 13: present in the proper place when testing this code.
This way we are duplicating the real storage code in the test code, and then we will have to maintain both versions and keep them synced.

Can we change VolumeMetadata so it does not touch the filesystem, but instead uses some other object that we can replace in the tests?

Same way we are replacing now the metadata with a dict.
Line 14: 
Line 15: Change-Id: I1e09b3e2199c638452214de4c2e4dfd826b51242


-- 
To view, visit https://gerrit.ovirt.org/48695
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e09b3e2199c638452214de4c2e4dfd826b51242
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list