Change in vdsm[master]: v2v: add import thread as a member

nsoffer at redhat.com nsoffer at redhat.com
Tue Nov 17 14:10:47 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: v2v: add import thread as a member
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/48600/3/vdsm/v2v.py
File vdsm/v2v.py:

Line 371:         return obj
Line 372: 
Line 373:     def start(self):
Line 374:         self._thread = concurrent.thread(self._run_command)
Line 375:         self._thread.daemon = True
Not needed, this is one of the reason for using concurrent.thread instead of a bare Thread.
Line 376:         self._thread.start()
Line 377: 
Line 378:     def wait(self):
Line 379:         if self._thread is not None and self._thread.is_alive():


-- 
To view, visit https://gerrit.ovirt.org/48600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30f21c00f520f67d199c39376cbaf053025a60c2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list