Change in vdsm[master]: hooks: ovs: remove unused parameter

ibarkan at redhat.com ibarkan at redhat.com
Tue Nov 17 12:25:46 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: hooks: ovs: remove unused parameter
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/48267/3/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
File vdsm_hooks/ovs/ovs_before_network_setup_ovs.py:

Line 83:         commands.extend(_set_stp(attrs))
Line 84:     else:
Line 85:         commands.extend(['--', 'add-br', net, BRIDGE_NAME, str(vlan)])
Line 86:     if nic is not None:
Line 87:         commands.extend(_add_nic_port(net, nic, nets_by_nic))
> i don't understad, what 'this'?
vlan.
and it is removed. ok.
Line 88: 
Line 89:     running_config.setNetwork(net, attrs)
Line 90:     return commands
Line 91: 


-- 
To view, visit https://gerrit.ovirt.org/48267
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7d39a103d3c07ee46a7bc6cf17fe33165117f69
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list