Change in vdsm[master]: v2v: add import thread as a member

fromani at redhat.com fromani at redhat.com
Tue Nov 17 10:39:49 UTC 2015


Francesco Romani has posted comments on this change.

Change subject: v2v: add import thread as a member
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/48600/2/vdsm/v2v.py
File vdsm/v2v.py:

Line 375:         self._thread.daemon = True
Line 376:         self._thread.start()
Line 377: 
Line 378:     def wait(self):
Line 379:         if self._thread is not None and self._thread.isAlive():
minor: please use is_alive()
Line 380:             self._thread.join()
Line 381: 
Line 382:     @property
Line 383:     def id(self):


-- 
To view, visit https://gerrit.ovirt.org/48600
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30f21c00f520f67d199c39376cbaf053025a60c2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list