Change in vdsm[master]: gluster: Fixing connection when server is not one of the bricks
nsoffer at redhat.com
nsoffer at redhat.com
Tue Nov 17 08:54:53 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: gluster: Fixing connection when server is not one of the bricks
......................................................................
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/48308/9/vdsm/storage/storageServer.py
File vdsm/storage/storageServer.py:
Line 347:
Line 348: if not servers:
Line 349: return ""
Line 350:
Line 351: return "backup-volfile-servers=" + ":".join(servers)
> User could have a distributed replica volume (2 X 3) with 6 bricks. These 6
Ala, would add a patch of top of this one, removing duplicates?
Sahina, we are worried about a different scenario. Lets say we have servers A, B, and C.
The user is configuring the domain using server D, which is just another name for A or B or C. Lets assume that D is pointing now to A. The user explains on the bug why he is using configuration.
With this fix, we would mount D:/volname, with backup servers A:B:C.
First question, will gluster mount helper work correctly with 3 backup servers instead of 2? Will it use C, or ignore it and use only A and B as backup servers?
Next, lets assume that server D is failing. gluster mount helper will try to do
failover to the next backup server, but A is the same server, so it will fail as well. Then gluster mount helper will fail over to server B.
It this state, there is one brick (A and D are the same brick), but gluster mount
failed twice. Would it consider this as 2 failing bricks and the file system would become readonly, or it is smart enough to detect that there are 2 bricks online?
Line 352:
Line 353: def _get_gluster_volinfo(self):
Line 354: volinfo = supervdsm.getProxy().glusterVolumeInfo(self._volname,
Line 355: self._volfileserver)
--
To view, visit https://gerrit.ovirt.org/48308
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id3386b37cd407c52e1b8f38d54c236bffc143e2f
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Prasanna Kumar Kalever
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list