Change in vdsm[master]: vm: Remove empty RNG devices left after 3.5->3.6 upgrade
fromani at redhat.com
fromani at redhat.com
Tue Nov 17 08:40:27 UTC 2015
Francesco Romani has posted comments on this change.
Change subject: vm: Remove empty RNG devices left after 3.5->3.6 upgrade
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
please one more reformatting. Preliminar ack.
https://gerrit.ovirt.org/#/c/48621/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 4984: """
Line 4985: Returns True if dev is a legacy (3.5) RNG device conf,
Line 4986: False otherwise.
Line 4987: """
Line 4988: return dev['type'] == hwclass.RNG and \
minor: let's avoid this continuation (\ character):
return dev['type'] == hwclass.RNG and (
'specParams' not in dev or
'source' not in dev['specParams'
)
Line 4989: ('specParams' not in dev or
Line 4990: 'source' not in dev['specParams'])
Line 4991:
Line 4992: with self._confLock:
--
To view, visit https://gerrit.ovirt.org/48621
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2580dcb335970a4bb5c4c87fe6ea9fcd8e494df5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list