Change in vdsm[master]: hsm : Do not resize on disconnectStorageServer

frolland at redhat.com frolland at redhat.com
Tue Nov 17 08:15:00 UTC 2015


Freddy Rolland has posted comments on this change.

Change subject: hsm : Do not resize on disconnectStorageServer
......................................................................


Patch Set 2:

(4 comments)

https://gerrit.ovirt.org/#/c/48578/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-11-15 12:49:59 +0200
Line 4: Commit:     Fred Rolland <frolland at redhat.com>
Line 5: CommitDate: 2015-11-16 09:45:24 +0200
Line 6: 
Line 7: hsm : Do not resize on Disconnect Storage Server
> Lets use the verb name - disconnectStorageServer - this can make it easier 
Done
Line 8: 
Line 9: When a host is moved to maintenance state, it will
Line 10: disconnect from the connected storage servers.
Line 11: 


Line 6: 
Line 7: hsm : Do not resize on Disconnect Storage Server
Line 8: 
Line 9: When a host is moved to maintenance state, it will
Line 10: disconnect from the connected storage servers.
> from the connected -> from connected.
Done
Line 11: 
Line 12: Then, sdCache.refreshStorage() is called. It will rescan
Line 13: the devices, and an attempt to resize them is performed.
Line 14: 


Line 9: When a host is moved to maintenance state, it will
Line 10: disconnect from the connected storage servers.
Line 11: 
Line 12: Then, sdCache.refreshStorage() is called. It will rescan
Line 13: the devices, and an attempt to resize them is performed.
> and an attempt to resize them is performed  -> and attempt to resize device
Done
Line 14: 
Line 15: However, in case of disconnectStorageServer flow, resizing
Line 16: devices is not needed and may cause exceptions when trying
Line 17: to access sysfs when the iscsi connections are being removed,


Line 11: 
Line 12: Then, sdCache.refreshStorage() is called. It will rescan
Line 13: the devices, and an attempt to resize them is performed.
Line 14: 
Line 15: However, in case of disconnectStorageServer flow, resizing
> We already mentioned the verb in the title, so we can just say "in this flo
Done
Line 16: devices is not needed and may cause exceptions when trying
Line 17: to access sysfs when the iscsi connections are being removed,
Line 18: and needlessly delay the maintenance operation.
Line 19: 


-- 
To view, visit https://gerrit.ovirt.org/48578
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78e236a851b7a0e9ab8f3c86e180cc50fde4ad56
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list