Change in vdsm[master]: stomp: slow data read when connected from localhost

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Nov 16 20:57:24 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: stomp: slow data read when connected from localhost
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/48608/1/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:

Line 346
Line 347
Line 348
Line 349
Line 350
> Why the command line tool is different? It should not matter if you run loc
It does matter from where we connect.

The flow is as follows:
1. We connect to vdsm send CONNECT and SUBSCRIBE frames
2. VDSM responds with CONNECTED frame
3. We send SEND frame to invoke getVdsCaps
4. VDSM responds with MESSAGE which size is bigger than 4096
5. Client gets an event to read because network frame arrived
   (Difference is with this step. When we are remote we  
    receive bunch of events corresponding to network packets
    whereas in local connection there is single event 
    because data was never split into packets) 
6. We read amount of data which is equal to buffer size
7. In around 5 (hardcoded) sec we get heartbeat and we finish
   reading missing part of the message.


-- 
To view, visit https://gerrit.ovirt.org/48608
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I279b2cde25ed9bb42954cf8f72673bd0aad0a6a5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list