Change in vdsm[master]: hooks: ovs: better rollback

phoracek at redhat.com phoracek at redhat.com
Mon Nov 16 20:17:32 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: hooks: ovs: better rollback
......................................................................


Patch Set 14:

(1 comment)

https://gerrit.ovirt.org/#/c/46907/14/vdsm_hooks/ovs/ovs_before_network_setup.py
File vdsm_hooks/ovs/ovs_before_network_setup.py:

Line 73:             non_ovs_bonds[bond] = attrs
Line 74:     return ovs_nets, non_ovs_nets, ovs_bonds, non_ovs_bonds
Line 75: 
Line 76: 
Line 77: def _destroy_ovs_nets(initial_config, running_config):
> maybe add 'libvirt' to the function name? (and log msg)
Done
Line 78:     hooking.log('Removing OVS networks: %s %s' %
Line 79:                 (initial_config, running_config))
Line 80:     for libvirt_ovs_nets in (iter_ovs_nets(running_config.networks),
Line 81:                              iter_ovs_nets(initial_config.networks)):


-- 
To view, visit https://gerrit.ovirt.org/46907
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f6b63d03bb9579e260bfad1686047a431f69543
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list