Change in vdsm[master]: hooks: ovs: fix getVdsCaps and getVdsStats

phoracek at redhat.com phoracek at redhat.com
Mon Nov 16 11:57:10 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: hooks: ovs: fix getVdsCaps and getVdsStats
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/48263/4/vdsm_hooks/ovs/ovs_after_get_caps.py
File vdsm_hooks/ovs/ovs_after_get_caps.py:

Line 79:     ovs_networks_caps = {}
Line 80:     dhcpv4ifaces, dhcpv6ifaces = netinfo._get_dhclient_ifaces()
Line 81:     routes = netinfo._get_routes()
Line 82:     for network, attrs in six.iteritems(running_config.networks):
Line 83:         if is_ovs_network(attrs):
> don't we have an _iter_ovs_nets or something implementing this iteration?
Done
Line 84:             interface = network if 'vlan' in attrs else BRIDGE_NAME
Line 85:             net_info = _get_net_info(attrs, interface, dhcpv4ifaces,
Line 86:                                      dhcpv6ifaces, routes)
Line 87:             net_info['iface'] = network


https://gerrit.ovirt.org/#/c/48263/4/vdsm_hooks/ovs/ovs_after_get_stats.py
File vdsm_hooks/ovs/ovs_after_get_stats.py:

Line 36:     """Get OVS networks from RunningConfig and assign them network stats
Line 37:     dictionaries from underlying devices. Fake bridges and bonds already have
Line 38:     stats with their names.
Line 39: 
Line 40:     Note, that it take some time for a new device to appear in stats, so we
> 'may take' or 'takes'
Done
Line 41:     first check if the device we got from running_config is already reported.
Line 42:     """
Line 43:     ovs_networks_stats = {}
Line 44:     running_config = RunningConfig()


-- 
To view, visit https://gerrit.ovirt.org/48263
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc8298a737fccea626b4419bd7d462cc830afc2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list