Change in vdsm[master]: logging: Don't crash on non-ASCII in SimpleLogAdapter
mzamazal at redhat.com
mzamazal at redhat.com
Mon Nov 16 13:10:44 UTC 2015
Milan Zamazal has posted comments on this change.
Change subject: logging: Don't crash on non-ASCII in SimpleLogAdapter
......................................................................
Patch Set 3:
Let's summarize what we can do about this change:
# "Only strings, no unicodes in VDSM internals" rule was discussed. If there
is a rule, it must be visibly documented. Any objections against adding it to
VDSM Coding Guidelines on Wiki?
# According to the rule above, this change is indeed not a solution of the
original bug, just a workaround. But it's still useful IMHO, see the updated
commit message. So we can work on it independently of the original bug.
# Another solution should be found for the original bug. There are already some
proposals by Nir, unrelated to this change, no need to further discuss that here.
--
To view, visit https://gerrit.ovirt.org/48542
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1930817ade1799b218913348ffa099aab2211ef7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No
More information about the vdsm-patches
mailing list