Change in vdsm[master]: stomp: slow data read when connected from localhost

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon Nov 16 14:18:24 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: stomp: slow data read when connected from localhost
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/48608/1//COMMIT_MSG
Commit Message:

Line 20: delays reading response from calls like getVdsCaps for around 5 seconds.
Line 21: 
Line 22: We solved this issue by checking whether stomp frame was parsed from
Line 23: data read and if the size of this data equals to buffer size and
Line 24: connection is local we attempt to read again.
> Do we use asyncore for this? We should read whenever socket is readable, fi
localhost is special case as described above.

In prod we would be notified about each packet arriving for localhost we have single data arrived event where data size can be much bigger than our buffer size. For remote connections code works fine.

I introduced localhost check because I do not want to perform the same logic in prod envs.
Line 25: 
Line 26: 
Line 27: Change-Id: I279b2cde25ed9bb42954cf8f72673bd0aad0a6a5


-- 
To view, visit https://gerrit.ovirt.org/48608
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I279b2cde25ed9bb42954cf8f72673bd0aad0a6a5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list