Change in vdsm[master]: stomp: slow data read when connected from localhost
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Mon Nov 16 14:59:09 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: slow data read when connected from localhost
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/48608/1/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 354:
Line 355: if (parser.pending == 0 and
Line 356: size == self._bufferSize and
Line 357: dispatcher.socket.getpeername()[0] == '127.0.0.1'):
Line 358: self.handle_read(dispatcher)
> and if it exactly buffer_size msg? what will happen?
Exact size is not an issue because we also check whether there was frame parsed from the data.
I will add comment so people looking at the code will understand why the check was introduced.
Line 359: except socket.error:
Line 360: dispatcher.handle_error()
Line 361: return
Line 362:
--
To view, visit https://gerrit.ovirt.org/48608
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I279b2cde25ed9bb42954cf8f72673bd0aad0a6a5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list