Change in vdsm[master]: lib: Use new concurrent.thread() utility

danken at redhat.com danken at redhat.com
Mon Nov 16 08:46:36 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: lib: Use new concurrent.thread() utility
......................................................................


lib: Use new concurrent.thread() utility

This series eliminates some boilerplate code by using the new
concurrent.thread() utility for creating threads.

Mostly this does change the behavior of the existing code, except:

- Thread that did not use @utils.traceback to prevent silent failures
  are protected now automatically.

- Non-daemon threads are now daemon threads that will never block the
  application during shutdown. I believe this behavior is always what we
  want, so I did not separated this change to another patch.

The series includes various patches by subsystem: lib, storage,
networking, virt, and infra.

This patch updates the vdsm library to use the new utility.

Behavior changes:

- concurrent.tmap threads are protected from silent failures
- netlink/monitor.Monitor threads are protected from silent failures
- profiling/memory viewer thread is protected from silent failures

Change-Id: Id98bcdf7bb6c67583d9d994781e642441c9b8bdd
Relates-To: https://bugzilla.redhat.com/1141422
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/44895
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/concurrent.py
M lib/vdsm/executor.py
M lib/vdsm/libvirtconnection.py
M lib/vdsm/netlink/monitor.py
M lib/vdsm/profiling/memory.py
M lib/vdsm/schedule.py
M lib/vdsm/xmlrpc.py
7 files changed, 17 insertions(+), 24 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/44895
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id98bcdf7bb6c67583d9d994781e642441c9b8bdd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list